On May 20, 2015, at 2:42 PM, Matteo Bruni matteo.mystral@gmail.com wrote:
2015-05-20 20:40 GMT+02:00 Ken Thomases ken@codeweavers.com:
dlls/ntdll/directory.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)
Not sure it matters in practice but it might be better to check for HAVE_SYS_VNODE_H in both the definition of and the call to read_directory_getattrlist().
Hmm. I think it's OK. The code is currently guarded by HAVE_GETATTRLIST. Since ATTR_CMN_OBJTYPE is defined in terms of the type codes, they must be available.
Including sys/vnode.h is just the way to pull in the definitions in the current SDK. It's conceivable, for example, that the types may migrate to sys/attr.h and the include of sys/vnode would be unnecessary/pointless. In other words, what's important is that the type codes are defined, not necessarily that we can include this particular header.
-Ken