On Di, 2008-12-23 at 14:24 +0100, Stefan Dösinger wrote:
I'm only afraid of this hypothetical scenario:
- We remove a test because it breaks on $NONSTANDARDWINDRV
We disable the test with: if (0) { /* that crash on $NONSTANDARDWINDRV */ <full test here> }
- Some future patch changes this behavior
- The test doesn't warn us because it was removed
Of course, the disabled test does not protect us from the scenario above, but the test is still available for documentation.
IMHO it is better to use broken() wherever possible, although with a crash that is hard to do.
using broken() on a crashing test will not prevent the crash