Re: [PATCH 1/2] gdi32/tests: Add some more GetCharacterPlacement tests.

[Sven Baars]

On 17-02-2020 16:24, Huw Davies wrote:
> On Mon, Feb 17, 2020 at 10:01:04AM +0100, Sven Baars wrote:
> > - pos[0] = -1;
> > - glyphs[0] = '!';
> > - result.nGlyphs = 20;
> > size2 = GetCharacterPlacementA(hdc, "Wine Test", 9, 0, NULL, 0);
> > ok(size2, "GetCharacterPlacementA failed!\n");
> > ok(size == size2, "GetCharacterPlacementA returned different result: %u vs %u\n", size2, size);
> > - ok(result.nGlyphs == 20, "Unexpected number of glyphs %u\n", result.nGlyphs);
> > - ok(glyphs[0] == '!', "Unexpected first glyph %s\n", wine_dbgstr_wn(glyphs, 1));
> > - ok(pos[0] == -1, "Unexpected caret position %d\n", pos[0]);
>
> There's little point in testing the values from the results structure if it's
> not passed to the function.  So leave these additional tests and initialisations
> out.

Of course. Those tests didn't make any sense. Sorry for that. I sent the
updated patches.

Sven