Re: [PATCH v4 1/2] nsiproxy: Convert the reply to ICMP_ECHO_REPLY in the output buffer.

[Huw Davies]

On Fri, Oct 15, 2021 at 03:39:25PM +0300, Gabriel Ivăncescu wrote:
> Because iphlpapi has no opportunity to convert the reply in async mode.
> Signed-off-by: Gabriel Ivăncescu
>
> Handles architecture differences and family (can be easily extended to
> support IPv6's struct).
>
> dlls/iphlpapi/iphlpapi_main.c        |  44 ++----------
>  dlls/nsiproxy.sys/device.c           | 100 ++++++++++++++++++++++++---
>  dlls/nsiproxy.sys/nsiproxy_private.h |  55 +++++++++++++++
>  include/wine/nsi.h                   |  21 +-----
>  4 files changed, 152 insertions(+), 68 deletions(-)

What does this look like if you do the conversion on the
unix side?  At the very least you'd cut out one buffer
copy.

Huw.