"Jeff Latimer" lats@yless4u.com.au wrote:
--- a/dlls/pdh/pdh_main.c +++ b/dlls/pdh/pdh_main.c @@ -837,14 +837,7 @@ PDH_STATUS WINAPI PdhLookupPerfNameByIndexA( LPCSTR machine, DWORD index, LPSTR
TRACE("%s %d %p %p\n", debugstr_a(machine), index, buffer, size);
- if (machine)
- {
FIXME("remote machine not supported\n");
return PDH_CSTATUS_NO_MACHINE;
- }
- if (!buffer || !size) return PDH_INVALID_ARGUMENT;
- if (!index) return ERROR_SUCCESS;
Changelog mentions PdhLookupPerfNameByIndexW by the change is in PdhLookupPerfNameByIndexA. Why are you removing the checks in one place by leave the same in other one? Why the tests are unnecessary?