Re: [PATCH v2] vbscript: Allow public and private declarations in global scope.

[Robert Wilhelm]

Hi Jacek,

Your version looks very nice.
Thanks a lot for your timely reviews and for cleaning up my patch.

Robert

On Mon, 2020-09-28 at 20:12 +0200, Jacek Caban wrote:
> Hi Robert,
>
> On 28.09.2020 12:47, Robert Wilhelm wrote:
> > v2: As suggested by Jacek, I moved the the dimdeclaration to
> > SourceElements.
> >      No more check is needed in compile_dim_statement.
> >      This adds one reduce/shift conflict regarding "Public
> > Default".
> >      It should be harmless as bison always shifts.
>
> It seems that simply partially duplicating Storage rule can avoid
> the
> conflict. As for the test bot, it seem that Windows is not
> consequent
> about how it reports the error, so I stripped that part and sent a
> new
> version.
>
> Thanks,
>
> Jacek