Re: [Fwd: QUARTZ: initialize AM_MEDIA_TYPE to prevent crash]

[Christian Costa]

I have already sent a fix (applied) for that 3 weeks ago.
You should have updated you tree before sending a patch. ;-)

Bye,
Christian

Alex Villací­s Lasso wrote:
> I am (still) trying to run a Japanese RPG program in Wine, and it 
> requires 1) the Indeo video codecs, fortunately downloadable, and 2) 
> this patch, to prevent crashing on an attempt to IUnknown_Release on a 
> bogus interface.
>
> Second attempt - first one never appeared on the mail list.
>
> Changelog:
> - Initialize mtCurrent structure to NULL to prevent calling
>
> IUnknown_Release on an uninitialized interface
>
> --- wine-20050524/dlls/quartz/pin.c	2005-05-06 09:34:44.000000000 -0500
> +++ wine-20050524-patch/dlls/quartz/pin.c	2005-06-26 20:48:48.000000000 -0500
> @@ -153,6 +153,7 @@
>     pPinImpl->pin.fnQueryAccept = pQueryAccept;
>     pPinImpl->pin.pUserData = pUserData;
>     pPinImpl->pin.pCritSec = pCritSec;
> -
>
> memset(&(pPinImpl->pin.mtCurrent), 0, sizeof(AM_MEDIA_TYPE));
> Copy_PinInfo(&pPinImpl->pin.pinInfo, pPinInfo);
>
> /* Input pin attributes */
>
> @@ -176,6 +177,7 @@
>     pPinImpl->pin.fnQueryAccept = pQueryAccept;
>     pPinImpl->pin.pUserData = pUserData;
>     pPinImpl->pin.pCritSec = pCritSec;
> -
>
> memset(&(pPinImpl->pin.mtCurrent), 0, sizeof(AM_MEDIA_TYPE));
> Copy_PinInfo(&pPinImpl->pin.pinInfo, pPinInfo);
>
> /* Output pin attributes */