Re: [PATCH 2/5] wsdapi: Add support for custom elements in SOAP header.

[Owen Rudge]

On 03/04/2018 11:58, Huw Davies wrote:
> I hate to keep saying it, but this should probably return HRESULT with
> the duplicated element being returned in a WSDXML_ELEMENT ** [out]
> parameter.  That would mean create_soap_header_xml_elements() should do likewise.
> The WSDXMLAddChild calls here in particular are screaming out for error
> propagation.

Thanks, I've resubmitted these patches using HRESULT error propagation 
where practical. I've amended a couple of existing functions in the 
first patch to return HRESULT, as these will be used fairly heavily in 
future patches.

Cheers,

Owen