On 22 August 2013 11:53, Stefan Dösinger stefan@codeweavers.com wrote:
I think it's best to check the pool in operations that accept a resource as parameter. We already do that in most places.
Yes, but if "pool" goes away we need some other way to check for scratch resources. It's just that in retrospect the access flags probably aren't the right place.
Wrt wined3d_volume_validate_location and wined3d_volume_invalidate_location: Should validate_location(LOCATION_X) just add LOCATION_X to the valid locations, or invalidate all others? (i.e., should it do a logical or or an assignment)? I currently implement it as logical or, so in some cases the caller is responsible for calling invalidate_location on the other locations.
Yes, logical or.