On Wed, May 1, 2019 at 9:51 PM Ethan Lee elee@codeweavers.com wrote:
Any suggestions on a new name? CommitChangesReal? For the suffix idea my plan would end up being to add the new function, deprecate the old function, then upon removing the old function, add it back with the correct signature and then deprecate the badly-named functions. This would apply to FAPOFX_CreateFX as well. I’m also up for suggestions on when to remove the deprecated functions.
If you cannot come up with a new name. I would personally go with CommitChanges2(). Other APIs use similar convention, e.g. vkCreateRenderPass2() and ID3D11DeviceContext1::CopySubresourceRegion1().