On 03/22/2010 07:59 AM, Ilya Basin wrote:
Hi! Sorry for being annoying, will you accept my patch? http://www.winehq.org/pipermail/wine-patches/2010-March/086009.html
Hi Ilya,
That's not up to us.
Whenever you sent a patch to wine-patch everybody is free to comment (or sent a reply that they agree in some specific cases). It's still however up to Alexandre whether a patch is accepted and committed.
I can't spot anything obviously wrong with your patch. I must admit that this SHELL32_execute function is huge so it could be worthwhile (in the future) to split things out of there.
The only thing I'm wondering is why this big piece was added in the first place (2004) but that in itself is of course no guarantee it was needed.
Is it possible to create more tests or is everything possible already catered for by that one test?