On 10/9/07, Stefan Dösinger stefan@codeweavers.com wrote:
Am Dienstag, 9. Oktober 2007 04:18:29 schrieb Allan Tong:
This patch moves the call to ActivateContext ahead of the opengl calls. This fixes a crash I was getting in the Bioshock demo where a newly created thread was calling glBindFramebufferEXT before a rendering context was established for the thread.
The patch is correct in spirit, ActivateContext has to be called before other gl stuff is done, but I have found that it causes some problems for an unknown reason. So perhaps other bugfixes are needed before this works properly. One of the problems was a major rendering problem in half life 2 lost coast.
I filed bug #9973 and attached the patch there in case it's useful to anyone else. In the meantime, though, perhaps a comment should be added to the code detailing the above reasons, lest someone else tries to make the same fix.
- Allan