On Thu, Sep 3, 2015 at 10:17 PM, Zhenbo Li litimetal@gmail.com wrote:
Hi Bruno,
Thanks for your comments.
2015-09-03 16:04 GMT+08:00 Bruno Jesus 00cpxxx@gmail.com:
Hi, I dislike the idea of removing tests because they are obsolete but that is just my opinion. At least I like to keep winsock running in NT4.
Do you know how I can get the test result in NT4? I have no idea about that.
Not really, I run tests manually. I don't think you should bother about that.
What I have done in patches that reached similar issues is to detect the OS using a specific test that you are sure differs between OS and then use if/else to separate the tests. This reduces the amount of broken required, broken can be a vilain sometimes because it does not specify which OS is failing.
How about this soultion? ok(retval == value1 || broken(retval == value2) || broken(retval == value3) ...) switch(retval) { case value1:... case value2:... case value3:... }
In this way, we can find the difference between OSs.
What I was thinking was more simple like:
retval = test_with_known_os_difference(); if(retval = VISTA_RESULT) { //all >= vista tests } else { //all xp + old broken tests }
Others may have different opinion, this is just the way I do =)