Re: [PATCH] advapi32: Allow for sending extended control events to services

[Sebastian Lackner]

On 08.08.2016 17:41, Aric Stewart wrote:
> This allows dwEventType and lpEventData parameters to be sent
> Signed-off-by: Aric Stewart
>
> dlls/advapi32/service.c | 36 ++++++++++++++++++++++++++++--------
>  include/wine/svcctl.idl | 11 ++++++++++-
>  2 files changed, 38 insertions(+), 9 deletions(-)

It might be useful to validate the parameters received from the control pipe
before assuming its safe to access the data. The existing code is also not
really perfect yet, however it wouldn't hurt to add some checks.

Nevertheless, even more important, it would also be good to combine this in
a series with the corresponding programs/services part, so that it can be
tested and we are sure this is the right way to solve it.

Best regards,
Sebastian