Re: [PATCH] msi: Print error number when GetProcAddress fails

[Hans Leidekker]

On Wed, 2017-08-16 at 17:20 +0100, Carlos Palminha wrote:
> diff --git a/dlls/msi/custom.c b/dlls/msi/custom.c
> index 922927e8903..cfdfe852efb 100644
> --- a/dlls/msi/custom.c
> +++ b/dlls/msi/custom.c
> @@ -608,7 +608,7 @@ static DWORD ACTION_CallDllFunction( const GUID *guid )
>              ERR("failed to create handle for %p\n", remote_package );
>      }
>      else
> -
>    ERR("GetProcAddress(%s) failed\n", debugstr_w( function ) );
> -
>    ERR("GetProcAddress(%s) failed: %d\n", debugstr_w( function ), GetLastError() );
>
> FreeLibrary(hModule);

This doesn't appear to add any useful information. Our implementation of
GetProcAddress sets either ERROR_PROC_NOT_FOUND or ERROR_MOD_NOT_FOUND and
LoadLibrary must have succeeded before reaching this code.