Re: [PATCH 1/5] iphlpapi/tests: Add tests for GetBestInterface.

[Huw Davies]

On Sun, Jan 16, 2022 at 01:32:31AM +0900, Jinoh Kang wrote:
> Signed-off-by: Jinoh Kang
>
> dlls/iphlpapi/tests/iphlpapi.c | 26 +++++++++++++++++++++++++-
>  1 file changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/dlls/iphlpapi/tests/iphlpapi.c b/dlls/iphlpapi/tests/iphlpapi.c
> index 12da629c30c..f9044c685c5 100644
> --- a/dlls/iphlpapi/tests/iphlpapi.c
> +++ b/dlls/iphlpapi/tests/iphlpapi.c
> @@ -1456,9 +1456,32 @@ static void testGetNetworkParams(void)
>      }
>  }

Hi Jinoh,

Are you intending to work on the implementations of these functions or
is this series all there is?  I ask because if you have patches for
the impementations, it may be better to send them along with the tests.
If these are just stand-alone tests I'll review them as is.

Thanks,
Huw.