Re: [PATCH 04/11] mfplat: Implement IMFAttributes::{SetItem, GetItem}.

[Jactry Zeng]

Hi Nikolay,

Thanks for review!

Nikolay Sivov  于2018年12月29日周六 上午1:09写道：
> On 12/28/18 6:42 PM, Jactry Zeng wrote:
> > +struct mfattribute
> > +{
> > - struct list entry;
> > - GUID key;
> > - PROPVARIANT value;
> >
> > +};
> > - typedef struct _mfattributes
> > {
> >     IMFAttributes IMFAttributes_iface;
> >     LONG ref;
> > - CRITICAL_SECTION lock;
> > - struct list attributes;
> > } mfattributes;
>
> Also GetItemByIndex() suggests array would be more appropriate.

Please correct me if I misunderstand anything.
Since it has IMFAttributes::DeleteItem which can delete any attribute
from that list, it seems that list can make thing more simple?
Or it will need to reorder the array every time an attribute is deleted.