Re: d3dcompiler_43: Avoid signed-unsigned integer comparisons

[Matteo Bruni]

2013/1/1 Andrew Talbot :
> Changelog:
>     d3dcompiler_43: Avoid signed-unsigned integer comparisons.
>
> diff --git a/dlls/d3dcompiler_43/bytecodewriter.c b/dlls/d3dcompiler_43/bytecodewriter.c
> index d10f6bc..17289d2 100644
> --- a/dlls/d3dcompiler_43/bytecodewriter.c
> +++ b/dlls/d3dcompiler_43/bytecodewriter.c
> @@ -609,7 +609,7 @@ static void write_declarations(struct bc_writer *This,
>  }
>
> static void write_const(struct constant **consts, int num, DWORD opcode, DWORD reg_type, struct bytecode_buffer *buffer, BOOL len) {
> - DWORD i;
> - int i;
> DWORD instr_def = opcode;
> const DWORD reg = (1<<31) |
>                   ((reg_type << D3DSP_REGTYPE_SHIFT) & D3DSP_REGTYPE_MASK) |

I think it's better if you turn the num parameter into an unsigned int
(or DWORD) instead.