2017-05-22 13:48 GMT+02:00 Paul Gofman gofmanp@gmail.com:
On 05/22/2017 02:28 PM, Matteo Bruni wrote:
Just an idea, maybe use %.8e to print the float values? Mostly for consistency with the usual d3d stuff, although in this case it doesn't matter much since you're also printing the bit encoding in hex.
I thought "%g" shows the values in a tiny bit more convenient way for viewing them (and as you pointed we have hex output for, e. g., copying the exact value from this output into the table). I actually found %g form of output handy when viewing these tests output. I have no problems changing it to ".8e" if you consider this better, but currently we are using "%g" throughout all the preshader tests, in this case I should probably do it throughout all the tests?
Yes, ideally all the strings would need to be changed, although on the other hand a patch just updating the ok() strings isn't particularly appealing and mine is a very mild suggestion to begin with. It's up to you, really.