On 15 January 2016 at 14:19, Jacek Caban jacek@codeweavers.com wrote:
I don't think this should block the patch. We already use bit fields in Wine. Even if we ever find a problem with it (which is currently not the case AFAIK) and we'd need something special for Wine, we should still have a variant of declaration that is source compatible with PSDK (except probably ifdefed).
Probably.
At first sight I see some minor style issues like the brace placement after "union" in D3D11_VIDEO_COLOR, D3D11_OMAC_SIZE should probably be a constant, and I'm really not a fan of the parameter naming convention in ID3D11VideoContext either, but ultimately nothing that would necessarily block the patch. I didn't review the patch closely though, and it's not assigned to me.