On 03/12/14 19:05, Alexandre Julliard wrote:
Jacek Caban jacek@codeweavers.com writes:
Due to how tests are written, we need to switch to IWebBrowserPriv2IE9 in the same patch.
dlls/ieframe/ieframe.h | 2 +- dlls/ieframe/navigate.c | 104 +---- dlls/mshtml/Makefile.in | 1 + dlls/mshtml/htmldoc.c | 4 + dlls/mshtml/htmldoc7.c | 939 +++++++++++++++++++++++++++++++++++++++++++
Merging htmldoc3 and htmldoc5 was a good start, couldn't we do this with the rest of the htmldoc implementations too? There are way too many files in that dll already.
Yes, we could, however:
$ wc -l htmldoc*.c 2669 htmldoc.c 1294 htmldoc3.c 939 htmldoc7.c 4902 total
Those are still not all interfaces implemented by HTMLDocument and most of functions are stubs. Assuming that, when implemented, all those functions will be trivial Gecko API wrappers (most of them will be, but some will be rather complex), that's about 20000 lines already. That's way too much for my taste. I may merge those files and revisit it at some point in the future.
Jacek