Crash in dlls/comctl32/treeview.c

[Dmitry Timoshkov]

Hello all,

I've got a crash in Excel running a custom VB script.

A crash log with +treeview is attached.

As I see it, TVM_SORTCHILDREN causes firstVisible to become NULL,
and on next TVM_SETITEMA message, TREEVIEW_UpdateScrollBars is
called, which dereferences infoPtr->firstVisible, which is NULL.

I'm not sure whether attached patch is correct or not, but it fixes
a crash in Excel. The patch simply prevents TREEVIEW_Sort from setting
infoPtr->firstVisible to NULL.

Treeview gurus out there any comments?