On Sat, Aug 07, 2010 at 11:53:36AM +0200, David Adam wrote:
Hi,
what about if ppPin is NULL?
then it will crash spectacularly, which is exactly what the client throwing around invalid pointers deserves ;) the surrounding code assumes that it's passed valid pointers too.
anyway, dshow seems to require this, so added a check locally
I think that this patch needs test cases to prove that it is correct?
I'll try to write something, but i'm not familiar with wine/quartz API (i just wanted to get video playback in a game working :) ) so it might be problematic.
anyway, i've looked around some more and it seems that this function can be shared for all IBaseFilter subclasses. same probably goes for some other, e.g. IBaseFilter_EnumPins. is there a reason they're not?
Anton Khirnov