Re: [PATCH 2/3 v2] ntdll: Leave some space around DbgBreakPoint and DbgUserBreakPoint.

[Huw Davies]

On Wed, Jun 24, 2020 at 09:13:40AM +0200, Alexandre Julliard wrote:
> Rémi Bernon  writes:
> > CoD: Black Ops 3 and CoD: WWII modify these (and several others) and
> > expect to have enough space for a few instructions.
> >
> > It then verifies later that the patches are still in place, and
> > terminates if the byte sequence do not match. Having small symbols can
> > make the patches to overlap and the check to fail.
> > Signed-off-by: Rémi Bernon
> >
> > v2: Use .skip instead of .nops which doesn't work with old binutils,
> > also fix the size on x86_64.
>
> Is .skip truly portable?  In winebuild we had to avoid it on macOS
> because it wasn't supported, I don't know if that's still true.

This works at least with Xcode 9 command-line tools (which is the last
version to support 32-bit).

Huw.