On Tue, 28 Sept 2021 at 16:43, Jan Sikorski jsikorski@codeweavers.com wrote:
On 27 Sep 2021, at 20:47, Henri Verbeet hverbeet@gmail.com wrote:
@@ -5115,6 +5115,9 @@ BOOL wined3d_texture_vk_prepare_texture(struct wined3d_texture_vk *texture_vk, if (wined3d_format_is_typeless(&format_vk->f) || texture_vk->t.swapchain) flags |= VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT;
- if (texture_vk->t.resource.bind_flags & WINED3D_BIND_UNORDERED_ACCESS)
flags |= VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT;This could probably be done as a separate change, and I think it deserves a comment that this is for creating views with a different format for UAV clears. We may as well use "else if", I guess.
I don’t see how it would fit in a separate change. Do you mean just setting this bit? Before the main patch it wouldn’t be used, and having the patch without it might cause crashes. Or do you mean creating the views code, in which case I guess I could put a FIXME there first?
I mean just setting VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT, yes. It's true that before the main patch there's nothing that depends on that bit being set, but it would still be a change in behaviour; in that sense it would still make sense as a bisection point.