Re: [PATCH vkd3d 2/2] vkd3d-shader/hlsl: Implement floor().

[Nikolay Sivov]

On 12/13/21 14:23, Giovanni Mascellani wrote:
> Hi,
>
> On 13/12/21 12:15, Nikolay Sivov wrote:
> > Something like attached diff?
>
> That looks sensible, except that it should be:
> > if (type->base_type != HLSL_TYPE_FLOAT && type->base_type != 
> > HLSL_TYPE_HALF)
>
> We don't really handle half values so far (and it's not clear how they 
> differ from floats), but at least for typing I guess it makes sense to 
> do the right thing, given that it's easy.

The way you tested with overloaded functions, half is handled the same 
as int.
> Thanks, Giovanni.