"Anatoly Lyutin" vostok@etersoft.ru wrote:
-/** +WINE_DEFAULT_DEBUG_CHANNEL(start);
+/*
All these changes /** -> /* make the diff larger, and are not really necessary.
Output given message to stdout without formatting. */ -static void output(const char *message) +static void output(const WCHAR *message) { DWORD count;
- WriteFile(GetStdHandle(STD_OUTPUT_HANDLE), message, strlen(message), &count, NULL);
- DWORD res;
- int wlen = strlenW(message);
Once you change your editor settings to use natural 8 spaces for a tab you will see how ugly the formatting in your new code is.
-static void fatal_error(const char *msg, DWORD error_code) +static void fatal_error(const WCHAR *msg, DWORD error_code)
fatal_error() is not called with strings outside of ASCII charset, so there is no much point in converting it to unicode. It only makes your patch full of controversial changes. IMHO fatal_error() should be removed altogether, and replaced by proper error handling instead.