On Tue, Apr 26, 2022, 11:11 Mohamad Al-Jaf mohamadaljaf@gmail.com wrote:
On Tue, Apr 26, 2022 at 2:38 AM Huw Davies huw@codeweavers.com wrote:
I don't think it's unreasonable to wait for Austin to send in his own patches (especially as you're asking the reviewer to wait until Austin sends his sign-off). I appreciate that you've made some changes, but this would be better done in response to a patch that's actually on the mailing list. That way the reviewer can easily follow the progress, unlike the way this was done, which just left me confused about where v1 was.
You're right, it's not unreasonable to wait for him to send it on his own, but I just appreciated his input in the mshtmlmedia thread and wanted to show my gratitude by confirming the wine-bug, and confirming his patch, hence the sign-off from me. I made a Twitch account just to test his patch.
I normally wouldn't do something like this, people can submit their patch on their own and they should, it's their work after all. And to be honest I'd much rather stick to my own work. I just wanted to save him the trouble of doing it himself. I take no credit for this patch.
If he wants to resubmit under his name it's completely fine by me and I'm more than happy to sign-off on the patch, well, that is if my sign-off has any bearing.
I apologize in advance if he didn't want this.
-- Kind regards, Mohamad
I didn't originally add my sign of because the patch wasn't tested.
I have no problem with you taking over the patch, thanks for checking.
I'm traveling for the next couple weeks, anyway, so won't have a chance to do much with it for a while.