Re: [PATCH v2 1/6] winegstreamer: Support MPEG-1 audio in wg_transform.

[Zebediah Figura (she/her)]

On 5/4/22 02:58, Anton Baskanov wrote:
> Signed-off-by: Anton Baskanov
>
> v2:
> - Added "parsed" field to MPEG-1 audio caps.
> - Allow mpg123audiodec to be used.
> - Use WG_MAJOR_TYPE_AUDIO instead of WG_MAJOR_TYPE_MPEG1_AUDIO.
>
> dlls/winegstreamer/wg_format.c    | 29 +++++++++++++++++++++++++++++
>   dlls/winegstreamer/wg_transform.c | 13 +++++++++++++
>   2 files changed, 42 insertions(+)

Okay, I'm convinced, making it a new major type is better after all :-)

I was kind of on the fence anyway; conceptually it probably is better 
that way, given that we've been making other compressed formats into 
separate major types, and if you take this patch into account the code 
actually does get simpler.

I'll send a new revision that reverts to your initial 1/7, combined with 
the other changes from v2.