Re: [PATCH] winex11drv: Fix uninitialized memory access appearing in multiple tests (Valgrind) (resend)

[Nikolay Sivov]

On 05/21/2015 08:05 AM, [e-mail] wrote:
> From: Indrek Altpere
>
> dlls/winex11.drv/window.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/dlls/winex11.drv/window.c b/dlls/winex11.drv/window.c
> index 06e2294..de39a44 100644
> --- a/dlls/winex11.drv/window.c
> +++ b/dlls/winex11.drv/window.c
> @@ -701,6 +701,7 @@ static void set_size_hints( struct x11drv_win_data *data, DWORD style )
>   static void set_mwm_hints( struct x11drv_win_data *data, DWORD style, DWORD ex_style )
>   {
>       MwmHints mwm_hints;
> -
>
> memset(&mwm_hints, 0, sizeof(mwm_hints));
>
> if (data->hwnd == GetDesktopWindow())
>  {

This looks too much, isn't it enough to just set input_mode = 0 once, 
before making a call?