Re: [PATCH 1/3] gdi32/tests: Test BitBlt() to an enhanced metafile.

[Charles Davis]

Dmitry Timoshkov wrote:
> "Charles Davis"  wrote:
> > - if(1 || compare_emf_bits(hMetafile, EMF_BITBLT, sizeof(EMF_BITBLT),
> > -
> >    "emf_BitBlt", FALSE) != 0)
> > - {
> > -
> >    dump_emf_bits(hMetafile, "emf_BitBlt");
> > -
> >    dump_emf_records(hMetafile, "emf_BitBlt");
> > - }
>
> You forgot to remove if (1).

It goes away in patch #3. I thought I already had this discussion with
Paul.

There's a reason it's there. EMF_BITBLT contains two BitBlt() records,
but the EMF we're comparing it to only has one. That's because one of
them is if(0)'d out because it crashes on Wine. So, if we try to compare
the EMF we produced to the EMF we expect, it will fail. Last I checked,
Alexandre doesn't like it when tests fail. All tests must pass on his box.

Chip