Re: [PATCH] wined3d: Fix the size parameter of glVertexAttrib*Pointer().

[Józef Kucia]

On Wed, Jul 13, 2016 at 2:48 AM, Guillaume Charifi
 wrote:
> The mistake is obvious when looking at the GL 3.0 spec:
>   p29:
>     void VertexAttribPointer(uint index, int size, enum type, boolean normalized, sizei stride, const void *pointer);
>     void VertexAttribIPointer(uint index, int size, enum type, sizei stride, const void *pointer);
>
> p30:
>     Command               Sizes
>     VertexAttribPointer   1, 2, 3, 4
>     VertexAttribIPointer  1, 2, 3, 4
> Signed-off-by: Guillaume Charifi
>
> dlls/wined3d/state.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This looks wrong to me. The "gl_vtx_format" field is equal to the
"component_count" field. There's one exception though, the
"gl_vtx_format" is set to GL_BGRA for WINED3DFMT_B8G8R8A8_UNORM.
GL_BGRA was added as an accepted value by GL_ARB_vertex_array_bgra
(core since OpenGL 3.2).

What are you trying to fix?