Re: [PATCH 2/2] oledb32: GetConversionSize shouldn't fail for null variants.

[Alistair Leslie-Hughes]

Hi Huw,

On 22/12/15 20:56, Huw Davies wrote:
> On 22 Dec 2015, at 09:28, Nikolay Sivov wrote:
> > With previous patches my question was to test actual string this variant
> > is converted too, maybe it's not that magic after all.
>
> Looks like there's already a test for this (see the end of test_converttostr).
> It doesn't return a string, but returns status DBSTATUS_S_ISNULL.
>
> I think, given that's the case, you should add a comment above the new test,
> stating that Windows returns 110, but we're not testing it.  Also remove the
> initialization of dst_len before the call, since if we're not testing it there's no
> need to initialize it.

Sure I can live with that.

Alistair