Re: [PATCH v2 4/4] winehid: Implement handing internal ioctls

[Aric Stewart]

On 10/14/16 6:35 AM, Sebastian Lackner wrote:
> On 14.10.2016 06:25, Aric Stewart wrote:
> > Yup, rebased and resent
> >
> > thanks!
> > -aric
>
> Actually I was thinking about an even more simplified solution like:
>
> --- snip ---
> static NTSTATUS WINAPI internal_ioctl(DEVICE_OBJECT *device, IRP *irp)
> {
>     /* All these are handled by the lower level driver */
>     IoSkipCurrentIrpStackLocation(irp);
>     return IoCallDriver(((HID_DEVICE_EXTENSION *)device->DeviceExtension)->NextDeviceObject, irp);
> }
> --- snip ---
>
> The function in winebus also has tracing for unsupported ioctls for example.
> Does that make sense, or do you prefer to keep the IoControlCode checks
> (even if we do not seem to need them yet).
>
> Regards,
> Sebastian

I think I prefer keeping the IoControlCode checks and having an explicit passthrough of only the HID things for now. Thought I realized you had removed the ntoskrnl dependency so my v3 patch is incorrect. Working a v4.

-aric