Re: [PATCH] uxtheme: fixed the todo blocks in the SetWindowTheme tests. [try 2]

[James Hawkins]

On Tue, Oct 28, 2008 at 2:29 AM, Reece Dunn  wrote:
> Hi,
>
> This fixes the todo blocks in the SetWindowTheme tests.
>
> Changes:
>  v2 -- initialise the hr variable so that it is initialised in the
> case where hwnd is a valid window handle.

Please fix your changelog entry to describe the *fix*, not the end
result (getting rid of todo_wine's).  Also,

+    HRESULT hr = S_OK;
     TRACE("(%p,%s,%s)\n", hwnd, debugstr_w(pszSubAppName),
           debugstr_w(pszSubIdList));
-    hr = UXTHEME_SetWindowProperty(hwnd, atSubAppName, pszSubAppName);
+    if(!IsWindow(hwnd))
+        hr = E_HANDLE;
+    if(SUCCEEDED(hr))
+        hr = UXTHEME_SetWindowProperty(hwnd, atSubAppName, pszSubAppName);
     if(SUCCEEDED(hr))
         hr = UXTHEME_SetWindowProperty(hwnd, atSubIdList, pszSubIdList);
     if(SUCCEEDED(hr))

This code is screaming for a goto.