I noticed that fs was replaced by tid in relay (and snoop & co too now). I propose a slightly different version based on the following premises:
* when suspecting a threading problem it could be nice to tag each trace with the id of the thread that emits it
* when there's no thread issue, then fs and tid are unnecessary and only clutter the traces by making lines longer and harder to read
* I find that lines are more readable if the thread id comes first as it's always the same length and doesn't mess up the alignment of the other fields
So this patch adds a debug channel called 'tid' which activates printing the tid as the first field of all traces. Actually, it might make sense to merge 'tid' with the 'thread' debug channel.
'Screenshot':
08063178:Call user32.DispatchMessageA(405b6e50) ret=00402135 08063178:trace:relay:WINPROC_CallWndProc (wndproc=0x401c74,hwnd=00000138,msg=WM_SYSCOMMAND,wp=0000f060,lp=00000000) 08063178:Call user32.DefWindowProcA(00000138,00000112,0000f060,00000000) ret=0040206c
Comments?
Changelog:
* dlls/ntdll/ntdll.spec Declare the tid debug channel
* dlls/ntdll/debugtools.c, relay32/relay386.c, relay32/snoop.c Output the current thread id as the first field if tid is turned on
-- Francois Gouget fgouget@free.fr http://fgouget.free.fr/ La terre est une bêta...