On Sunday, March 20, 2011 4:37:07 PM Vitaliy Margolen wrote:
On 03/20/2011 05:14 AM, Pali Rohár wrote:
Can anybody review my patch?
Not sure what you trying to do exactly. Wine already has wrapper that makes all wine binaries executable after they are being installed into system.
Wine installs wrapper scripts which call wine with the appropriate .exe.so DSO. The .exe.so file can't be run directly.
As far as I can tell, the patch makes it so the .exe.so file can be run directly, by adding a _start section that automatically execs wine with all the same arguments passed on the command line. As a result, it removes the .so extension so you can, for example, just run the 'winecfg.exe' executable itself, with no 'winecfg' wrapper script needed.
This stuff isn't an area I'm familiar with, so I can't really comment on the patch itself.