Re: [PATCH 2/2] ntdll: Deny file operations on mapping handles.

[Paul Gofman]

On 5/2/20 12:43, Jacek Caban wrote:
> Hi Paul,
>
> On 01.05.2020 19:17, Paul Gofman wrote:
> > diff --git a/server/fd.c b/server/fd.c
> > index 39fb419f25..8e547f53dc 100644
> > --- a/server/fd.c
> > +++ b/server/fd.c
> > @@ -2612,6 +2612,12 @@ DECL_HANDLER(read)
> >         if (!fd) return;
> >   +    if (fd->fd_ops->get_fd_type( fd ) == FD_TYPE_MAPPING)
> > +    {
> > +        set_error( STATUS_INVALID_HANDLE );
> > +        return;
> > +    }
>
> This should be probably changed in no_fd_read or, if mapping is for
> some reason different than other objects, introducing a separated
> read() for mapping objects.

Oh yeah, thanks. And there is actually already no_fd_read for mapping
object, so I just don't need anything like that.