On Wed, 9 May 2001, Dmitry Timoshkov wrote:
"Francois Gouget" fgouget@free.fr wrote:
- I scanned the source for TRACE/WARN/ERR/FIXME statements without a
terminating newline. There are few cases where this is justified because of following DPRINTFs. But most of the time there should be a \n otherwise the trace will not be flushed to disk immediately and the logs will look bad.
You forgot to remove redundant ' around %s in the traces when output is made by debugstr_a or debugstr_w. Actually you removed some of them, but not all.
Yes, I was not scanning specifically for that. I may have noticed one or two and fixed as I went, but I probably fixed very very few (just one?). And it's probably not as bad (it doesn't delay the printing of the trace). Also the problem is to find a grep that yields a usable list of places to check. Ah. Found something that could work: $ wg . "'%s'" | egrep ") *; *$" | grep debugstr_ | wc -l 10 $ wg . "'%s'" | egrep -v ") *; *$" | wc -l 142
(wg is my recursive grep script) But it's nice to see you volunteer for this work ;-)
-- Francois Gouget fgouget@free.fr http://fgouget.free.fr/ La terre est une bêta...