Re: [PATCH v4 4/7] comctl32/listbox: Use a helper to retrieve item data by index

[Huw Davies]

On Tue, Feb 12, 2019 at 03:47:00PM +0200, Gabriel Ivăncescu wrote:
> Signed-off-by: Gabriel Ivăncescu
>
> dlls/comctl32/listbox.c | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/dlls/comctl32/listbox.c b/dlls/comctl32/listbox.c
> index c84d317..34d555a 100644
> --- a/dlls/comctl32/listbox.c
> +++ b/dlls/comctl32/listbox.c
> @@ -127,6 +127,11 @@ static TIMER_DIRECTION LISTBOX_Timer = LB_TIMER_NONE;
>
> static LRESULT LISTBOX_GetItemRect( const LB_DESCR *descr, INT index, RECT *rect );
>
> +static ULONG_PTR get_item_data( const LB_DESCR *descr, UINT index )
> +{
> - return (descr->style & LBS_NODATA) ? 0 : descr->items[index].data;
>
> +}
> -

nit-pick (since I've commented on the next patch), could you group all of
the item helpers with is_item_selected()?

Huw.