On Thu, Mar 19, 2015 at 06:30:34PM +0100, Sebastian Lackner wrote:
On 19.03.2015 16:22, Andrew Eikum wrote:
dlls/kernel32/kernel32.spec | 4 +- dlls/kernel32/path.c | 97 +++++++++++++++++++++++++++++++++++++++++++++ dlls/kernel32/tests/file.c | 88 ++++++++++++++++++++++++++++++++++++++++ include/winbase.h | 2 + 4 files changed, 189 insertions(+), 2 deletions(-)
Why do you do the work twice? It would have been much easier if you would have just helped us to review and improve our Staging patchset which is there since about half a year ago, and supports a lot more flags.
https://github.com/wine-compholio/wine-staging/blob/master/patches/kernel32-... https://github.com/wine-compholio/wine-staging/blob/master/patches/kernel32-...
Why does noone bother anymore to test those patches, the author Michael Müller asked for feedback there long time ago: https://bugs.winehq.org/show_bug.cgi?id=36073#c4
I'll submit the patches in a few minutes so that you can decide if its better/worse than the current approach.
The patch you linked certainly looks better, though note that the A version seems to have the same problem that Nikolay pointed out.
Andrew