Re: [PATCH 1/3] kernel32: Support UTF-7 in MultiByteToWideChar. (try 3)

[Alex Henrie]

2014-10-17 1:53 GMT-06:00 Henri Verbeet :
> The code would probably benefit from a helper function for the base64
> decoding, instead of having a nested do-while loop. Also, it's
> pointless to have an else-block if you unconditionally break / return
> in the preceding if-block. Similarly, if you have an unconditional
> break / return in an else-block, it probably should have just been an
> if-block instead.

OK. I've rewritten the inner loop of utf7_mbstowcs to not use else blocks.

I'm not sold on moving the inner loop to its own function, but we'll
see what Alexandre says.

-Alex