Alexandre Julliard julliard@winehq.org wrote:
You did get a comment from Huw that you need to allocate extra bytes, you still haven't done that AFAICS.
That was a just a question, to which I had answered. There are the tests, and the app which needs this functionality (and uses various fonts with different font sizes) works just fine with current approach.
Have you actually tested it with characters 32-pixel wide, and confirmed that Windows messes them up the same way?
What I have done is a comparison of screenshots of the affected application produced under Windows and Wine. If there will be a need in futher improvements I'll certainly have a look what can be enhanced.
Besides, status of the patches was New, both for the test and this implementation.
What has this got to do with anything? If your patch receives comments you have to address them, I'm not going to review it if someone else already did.
Shouldn't the patch status reflect that? Or commenting on a patch automatically makes it rejected? What about the test sent as 1/2? It has got no comments.