-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2014-01-03 20:39, schrieb Francois Gouget:
But independently from that I think it's wrong because one should be able to compile the conformance tests on Windows.
The purpose of this patch was to be able to compile the tests in msvc. But there may be some quirks in the build setup, see below.
So one solution would be to revert the patch. Another would be to copy wine/port.h's __port_nan() definition. Yet another might be to add xmath.h and a dependency on msvcrt.dll. But maybe there's a better way still?
NAN was available, and I assumed that I got the one from port.h. Admittedly I didn't check where exactly it came from. Maybe msvc 2013 added a NAN definition.
My msvc build setup is a bit quirky. I wanted to avoid needing a full mingw setup, so I ended up (over time, adding one detail after another) cloning a part of the Wine build system as a msvc project. I'll boot Windows and see where the NAN comes from exactly.