Re: ntdll / kernel32: #36

[Dmitry Timoshkov]

"Eric Pouech"  wrote:
> +static void INT21_ConvertFindDataAtoW(WIN32_FIND_DATAA *dataA,
> -
>                                  const WIN32_FIND_DATAW *dataW)
>
> +{
> - dataA->dwFileAttributes = dataW->dwFileAttributes;
> - dataA->ftCreationTime   = dataW->ftCreationTime;
> - dataA->ftLastAccessTime = dataW->ftLastAccessTime;
> - dataA->ftLastWriteTime  = dataW->ftLastWriteTime;
> - dataA->nFileSizeHigh    = dataW->nFileSizeHigh;
> - dataA->nFileSizeLow     = dataW->nFileSizeLow;
> - WideCharToMultiByte( CP_OEMCP, 0, dataW->cFileName, -1,
> -
>                     dataA->cFileName, sizeof(dataA->cFileName), NULL, NULL );
> - WideCharToMultiByte( CP_OEMCP, 0, dataW->cAlternateFileName, -1,
> -
>                     dataA->cAlternateFileName, sizeof(dataA->cAlternateFileName), NULL, NULL );
>
> +}

This is just a nit picking, but the function name above should be
changed to INT21_ConvertFindDataWtoA (and perhaps the arg sequence
should be changed as well). Of course, that could be done later,
after the patch is committed.