Re: [PATCH vkd3d 08/12] vkd3d-shader/hlsl: Parse matrix constructors.

[Giovanni Mascellani]

Hi,

Il 21/04/22 20:57, Zebediah Figura ha scritto:
> I dunno, I see the logic as not particularly complex...

Ok, given that Francisco reworked his patch in a rather different way, I 
did the same for mine. I am not really sure it's the ideal solution, but 
let's discuss it.
> I'm also slightly concerned that we're generating terrible code too 
> zealously. Simplicity of implementation is valuable, but it means that 
> optimization passes have more busywork to do, and this is one of those 
> cases where I'm not sure it's actually worth it...

The optimization step required this specific case is rather simple and 
already implemented. However, the new patch should please you better WRT 
point of view.

Thanks, Giovanni.