Qian Hong fracting@gmail.com writes:
Does the test run before or after patch [2/2] applied? If the failure is before patch [2/2] then it's expected because I didn't add todo_wine to [1/2]. I didn't add todo_wine because before [2/2] those test will success for some fonts on Wine and fail for the other fonts on Wine, and it seems doesn't make sense to test on only a few fonts.
Is the following solution acceptable?
- Swap the order of patch [1/2] and [2/2], add test cases after fix
the implementation .
Yes, that's OK. Tests need to succeed after every commit, even in the middle of a series.