Re: [PATCH 2/5] qedit: Stub out AMTimelineObj.

[Alex Henrie]

2016-04-26 7:29 GMT-06:00 Andrew Eikum :
> On Mon, Apr 25, 2016 at 09:09:57PM -0600, Alex Henrie wrote:
> > @@ -129,8 +129,14 @@ static HRESULT WINAPI Timeline_IAMTimeline_CreateEmptyNode(IAMTimeline *iface, I
> >                                                             TIMELINE_MAJOR_TYPE type)
> >  {
> >      TimelineImpl *This = impl_from_IAMTimeline(iface);
> > - FIXME("(%p)->(%p,%04x): not implemented!\n", This, obj, type);
> > - return E_NOTIMPL;
> > - HRESULT hr;
> > -
> > - TRACE("(%p)->(%p,%04x)\n", This, obj, type);
>
> Any reason for the 04 width specifier here and elsewhere? AFAICT
> they're not shorts, but maybe I'm missing something. I'd rather print
> them with "0x%x".

The 4-digit formatting was arbitrary. However, since the tests show
that the type is not a set of flags, and since it's defined in decimal
in the header file, I think %d makes the most sense.

-Alex