Re: [PATCH 1/2] devenum: Try to create unique keys for different video capture devices.

[Damjan Jovanovic]

On Sat, Apr 20, 2019 at 7:07 PM Zebediah Figura 
wrote:
> Signed-off-by: Zebediah Figura
>
> dlls/devenum/createdevenum.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/devenum/createdevenum.c b/dlls/devenum/createdevenum.c
> index 2db5491190..b89cac6d39 100644
> --- a/dlls/devenum/createdevenum.c
> +++ b/dlls/devenum/createdevenum.c
> @@ -795,7 +795,7 @@ static void register_avicap_devices(void)
>      friendlyname[5] = '0' + i;
>
> -
>    hr = register_codec(&CLSID_VideoInputDeviceCategory, name,
> -
>    hr = register_codec(&CLSID_VideoInputDeviceCategory, friendlyname,
>            &CLSID_VfwCapture, friendlyname, &prop_bag);
>    if (FAILED(hr))
>        continue;
>
> --
> 2.21.0

Currently the "name" is the device description, eg. "KWorld Webcam V2010
: KWorld ".
The "friendlyname" is "video0", "video1".
Shouldn't it be the other way around?

Also instead of passing friendlyname twice to register_codec(), shouldn't
we pass them both but in opposite order?

Just a thought.