Re: [PATCH] msvcp140: Add a dedicated _Equivalent method that allows for directories.

[Sven Baars]

Hi Piotr,

On 21-10-19 12:48, Piotr Caban wrote:
> Hi Sven,
> > -        { wine_test_dirW, wine_test_dirW, -1 },
> > +        { wine_test_dirW, wine_test_dirW, 1 },
>
> This change breaks the tests on some versions of msvcp140. Please mark
> the old behavior as broken.

That explains why the test was there in the first place. The tests I
did, as well as the tests on the test bot were actually failing. Thanks
for the information.
> Please add a helper function instead of duplicating the implementation.

I just duplicated what was done in the rest of the file. I'll also use
the helper for the other implementations in that case.

Thanks,
Sven